Attention is currently required from: Dolan Liu, Elyes Haouas, Eric Lai, Kapil Porwal, Matt DeVillier, Paul Menzel, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 25:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81773/comment/56a7e830_02383368 :
PS24, Line 9: In order to be different from rt5663, the driver of RT5645 is
: specially declared.
while the wording here is slightly awkward, I don't see enumerating the differences between the two […]
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/200dca0a_42bd74f3 :
PS24, Line 17:
or stated another way, the ACPI device is being created specifically for Linux
Done
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/660e91a0_c684ba82 :
PS24, Line 48: acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON);
Maybe add a comment here, that it is for Microsoft Windows.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 25
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 23 Apr 2024 01:16:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment