Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Johnny Lin, Jonathan Zhang, Tim Chu.
Martin L Roth has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/73746?usp=email )
Change subject: cpu/x86/smm: Save and restore UART 8250 state on all platforms
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This seems like a good plan if we're going to re-initialize the UART. The other option would be to just use whatever it's been set to, assuming that the remote terminal is set to the new settings and that updating the UART will mess up what's being received.
Maybe set up a Kconfig for whether to re-init in SMM?
Obviously this needs to be rebased as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73746?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e48cebdb56033dd976443a63fbbea3ae3488153
Gerrit-Change-Number: 73746
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 09 Sep 2024 18:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No