Attention is currently required from: CoolStar, Nick Vaccaro, Paul Menzel, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80718?usp=email )
Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80718/comment/fe282cc6_3f6f0588 :
PS2, Line 9: 9c348a7b7ea3422a74af9b820275751e9abb4a12
truncate to 12 digits
https://review.coreboot.org/c/coreboot/+/80718/comment/d32f8700_7f6fa901 :
PS2, Line 9: soc/intel/alderlake:
: Fix processor hang while plug unplug of TBT device
commit msg in quotes
https://review.coreboot.org/c/coreboot/+/80718/comment/db744c33_abd50028 :
PS2, Line 21: `
use 3-5 dashes vs single quotes?
File src/soc/intel/tigerlake/acpi/tcss_dma.asl:
https://review.coreboot.org/c/coreboot/+/80718/comment/07d95b3a_6b6624ed :
PS2, Line 15: /* ITBT FW Version Bit30 */
extra tab
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Gerrit-Change-Number: 80718
Gerrit-PatchSet: 2
Gerrit-Owner: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Comment-Date: Sun, 25 Feb 2024 19:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment