Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85228?usp=email )
Change subject: drivers/crb: Return an accurate status
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/85228/comment/46bc45dd_77299931?usp... :
PS1, Line 93: ptt_active
looks like you might need to guard using `HAVE_INTEL_PTT` as above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85228?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If8236021bf0e1264646971cff9c998fac99ac220
Gerrit-Change-Number: 85228
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Thu, 21 Nov 2024 18:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No