Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46951 )
Change subject: soc/intel/broadwell: Move romstage.c to Haswell ......................................................................
soc/intel/broadwell: Move romstage.c to Haswell
Broadwell no longer has CPU code.
Change-Id: I9c9717439a702dddaa613a30e6f3da29887ec4bd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/Makefile.inc R src/cpu/intel/haswell/romstage.c M src/soc/intel/broadwell/Makefile.inc 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/46951/1
diff --git a/src/cpu/intel/haswell/Makefile.inc b/src/cpu/intel/haswell/Makefile.inc index 3c4db4f..bfb5011 100644 --- a/src/cpu/intel/haswell/Makefile.inc +++ b/src/cpu/intel/haswell/Makefile.inc @@ -1,4 +1,6 @@ ramstage-y += haswell_init.c + +romstage-y += romstage.c romstage-y += ../car/romstage.c
ramstage-y += acpi.c diff --git a/src/soc/intel/broadwell/cpu/romstage.c b/src/cpu/intel/haswell/romstage.c similarity index 100% rename from src/soc/intel/broadwell/cpu/romstage.c rename to src/cpu/intel/haswell/romstage.c diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.inc index 7f42b1d..3f06913 100644 --- a/src/soc/intel/broadwell/Makefile.inc +++ b/src/soc/intel/broadwell/Makefile.inc @@ -2,8 +2,6 @@
subdirs-y += pch
-romstage-y += cpu/romstage.c - bootblock-y += bootblock.c
romstage-y += early_init.c
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46951
to look at the new patch set (#5).
Change subject: soc/intel/broadwell: Move romstage.c to Haswell ......................................................................
soc/intel/broadwell: Move romstage.c to Haswell
Broadwell no longer has CPU code.
Change-Id: I9c9717439a702dddaa613a30e6f3da29887ec4bd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/Makefile.inc R src/cpu/intel/haswell/romstage.c M src/soc/intel/broadwell/Makefile.inc 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/46951/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46951
to look at the new patch set (#7).
Change subject: soc/intel/broadwell: Move romstage.c to Haswell ......................................................................
soc/intel/broadwell: Move romstage.c to Haswell
Broadwell no longer has CPU code.
Change-Id: I9c9717439a702dddaa613a30e6f3da29887ec4bd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/Makefile.inc R src/cpu/intel/haswell/romstage.c M src/soc/intel/broadwell/Makefile.inc 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/46951/7
Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46951 )
Change subject: soc/intel/broadwell: Move romstage.c to Haswell ......................................................................
Patch Set 14: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46951 )
Change subject: soc/intel/broadwell: Move romstage.c to Haswell ......................................................................
soc/intel/broadwell: Move romstage.c to Haswell
Broadwell no longer has CPU code.
Change-Id: I9c9717439a702dddaa613a30e6f3da29887ec4bd Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46951 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/haswell/Makefile.inc R src/cpu/intel/haswell/romstage.c M src/soc/intel/broadwell/Makefile.inc 3 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/cpu/intel/haswell/Makefile.inc b/src/cpu/intel/haswell/Makefile.inc index 3c4db4f..bfb5011 100644 --- a/src/cpu/intel/haswell/Makefile.inc +++ b/src/cpu/intel/haswell/Makefile.inc @@ -1,4 +1,6 @@ ramstage-y += haswell_init.c + +romstage-y += romstage.c romstage-y += ../car/romstage.c
ramstage-y += acpi.c diff --git a/src/soc/intel/broadwell/cpu/romstage.c b/src/cpu/intel/haswell/romstage.c similarity index 100% rename from src/soc/intel/broadwell/cpu/romstage.c rename to src/cpu/intel/haswell/romstage.c diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.inc index dc16ae4..5e0ce64 100644 --- a/src/soc/intel/broadwell/Makefile.inc +++ b/src/soc/intel/broadwell/Makefile.inc @@ -1,7 +1,5 @@ ifeq ($(CONFIG_SOC_INTEL_BROADWELL),y)
-romstage-y += cpu/romstage.c - subdirs-y += pch
bootblock-y += bootblock.c
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)