Attention is currently required from: Martin Roth, Henry Sun, Evan Green, Justin TerAvest, Chen Wisley, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49469 )
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/49469/comment/fba61c43_47c2cb98
PS9, Line 17: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED)))
We had some discussion in the past for the same and decided not to allocate a FW_CONFIG bit - b/168280095.
Thanks for the pointer, Karthik!
But it turned out that the stylus here has internal pull-down. Hence the voltage level does not hit logic low when the stylus is present. So we have to avoid the pad termination ...
Is there a bug capturing the details of this stylus behavior? I am confused why internal pull-down prevents the voltage level from hitting logic low. Is the internal pull-down weaker than the pull-up being configured on the pad? Or is it not strong enough to be read as logic low?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 9
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 20 Jan 2021 18:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Evan Green
evgreen@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment