[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Arthur Heymans, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 13: Code-Review+2
(4 comments)
File src/ec/clevo/it5570e/ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/40bed4f2_6239958c PS4, Line 34: 0x2e
no, it's always the same as it's the standard superio port
From another comment: Clevo doesn't seem to use any other port. For now it should be OK.
File src/ec/clevo/it5570e/ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/1ffc29d0_a8352ab1 PS13, Line 120: dev->ops = &ec_ops; Future idea: use the shiny new `ops` devicetree syntax
File src/ec/clevo/it5570e/i2ec.h:
https://review.coreboot.org/c/coreboot/+/68791/comment/da3cfdda_e4fe5892 PS4, Line 10: #define D2ADR 0x2e
hopefully clearer now
Certainly clearer, yes. Thanks!
File src/ec/clevo/it5570e/i2ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/fce5df2c_3984b289 PS4, Line 11: 0x2e
reworked and successfully tested (by setting the cmos option for the keyboard backlight boot effect to enable/disable and read the ec register through the debugger interface).
Nice, thank you.
I decided to hardcode the PNP device, since no Clevo board uses 0x4e/0x4f anyways
But it's easy to change the `SIO_DEV` macro if need be, so it works for us. Thanks 😊
-
Angel Pons (Code Review)