[XL] Change in coreboot[main]: soc/meidatek/mt8196: Add SPM loader

[Yidi Lin (Code Review)]

Attention is currently required from: Ccong Chen, Hung-Te Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )

Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................

Patch Set 2:

(5 comments)

File src/soc/mediatek/common/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/d5d89e0e_4c93ea4c?usp... :
PS1, Line 59: #ifndef CONFIG_MEDIATEK_SPM_V2
> In 8196 SOC design, this part has been simplified, no need the part of setting

No done

https://review.coreboot.org/c/coreboot/+/85599/comment/8a38da6b_d3470a82?usp... :
PS1, Line 101: CONFIG_MEDIATEK_SPM_V2
> 8196 have not the register setting

not done

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/2fdbf6e7_cb866c99?usp... :
PS2, Line 87: #define AP_WDT_TIMEOUT_SUSPEND_S
Are you saying that the time unit is second ?

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/bf5b9719_634496e2?usp... :
PS1, Line 85: PCM_WDT_TIMEOUT
> Done

Not done. You don't even mention anything.

File src/soc/mediatek/mt8196/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/ed3eb7ed_71c427d5?usp... :
PS1, Line 861: 		SPM_REGWR_CFG_KEY | REG_SPM_APB_INTERNAL_EN_LSB |
> align line742 ?

align with first param.