Attention is currently required from: Patrick Georgi, Martin L Roth, ron minnich.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59958 )
Change subject: util/docker/coreboot.org-status: Rewrite parser ......................................................................
Patch Set 15: Code-Review+1
(5 comments)
Patchset:
PS15: Are you planning to create unit tests?
File util/docker/coreboot.org-status/board-status.html/logs.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/55b69eb2_148f40f2 PS15, Line 26: _ logging of this error is not required? https://github.com/golang/go/blob/master/src/io/fs/walk.go#L117
https://review.coreboot.org/c/coreboot/+/59958/comment/e096841d_a6b3aafa PS15, Line 61: item What happens if the string doesn't contain the ":" character? https://go.dev/play/p/6I70DRcEp_m check len(item) needed?
https://review.coreboot.org/c/coreboot/+/59958/comment/4f622eba_b87d83d0 PS15, Line 93: [3] check len(pieces) needed?
File util/docker/coreboot.org-status/board-status.html/status-to-html.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/4703b88f_3922e7d1 PS15, Line 71: dirs Why are you using the channel here? Why not a slice? In my opinion, it would be better to abandon multithreading to make the algorithm easier. How critical is performance?