Attention is currently required from: Felix Singer, Jason Nien, Jeremy Soller, Angel Pons, Martin Roth, Tim Crawford, Nico Huber, Tarun Tuli, Martin L Roth, Damien Zammit, Subrata Banik, Maxim Polyakov, Kapil Porwal, Alexander Couzens, Werner Zeh, Evgeny Zinoviev.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68982 )
Change subject: mainboard: Add SPDX license headers to Makefiles
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
@Martin: not sure if we already have this. […]
see util/lint/lint-000-license-headers; currently Makefile.inc is in the exclusion list
PS2:
What's the intended meaning to use GPL for Makefiles? Isn't it specifically […]
I guess the reason for applying a license at all is the same as when licenses were added to empty files: some company/companies complained about missing license headers.......... (Can't find the change right now)
Also, it is highly questionable if copyright does apply to many if not most of these Makefiles at all due to missing "height of creation". (also see e.g. CB:55456)
Anyway, adding a license wouldn't hurt - it's just weird and might cause confusion later.
Your main point is about which license to apply, right? Any suggestion for an alternative? I'd say GPL is fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic451e68b1ad9ccdf34484dd98bd7fca7e177ef22
Gerrit-Change-Number: 68982
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Sat, 29 Oct 2022 13:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Alexander Couzens
lynxis@fe80.eu
Gerrit-MessageType: comment