Attention is currently required from: Felix Held, Felix Singer.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83458?usp=email )
Change subject: util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
......................................................................
Patch Set 3:
(1 comment)
File util/find_usbdebug/find_usbdebug.sh:
https://review.coreboot.org/c/coreboot/+/83458/comment/d4f82921_cfebfe73?usp... :
PS2, Line 38: hubs_to_ignore="8087:0020 8087:0024"
is it intentional that this patch drops the existing IDs and completely replaces them? from the comm […]
Hmm, not sure what happened there. 0021 and 0026 aren't valid IDs for any Intel chipset with an EHCI rate matching hub. I must have been testing something before and forgot to change it back. Fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83458?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Gerrit-Change-Number: 83458
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 15 Jul 2024 18:33:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de