Change in coreboot[master]: nb/i945/bootblock.c: include <arch/pci_io_cfg.h> - coreboot-gerrit

31 Jan 2021


      Attention is currently required from: HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49537 )
Change subject: nb/i945/bootblock.c: include <arch/pci_io_cfg.h>
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49537/comment/ef348fef_024dd910 
PS3, Line 7: <arch/pci_io_cfg.h>
Note that <device/pci_ops.h> already includes <arch/pci_io_cfg.h> indirectly. I don't mind this change because we're only supposed to use I/O accesses here.
https://review.coreboot.org/c/coreboot/+/49537/comment/057b082f_e27a2be0 
PS3, Line 7: /
missing `intel/`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2aa8862de0f7629386ef09acbb0606056cc3697c
Gerrit-Change-Number: 49537
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 31 Jan 2021 10:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment