Change in coreboot[master]: soc/intel/common: Configure TCSS access through IOE P2SB

[Subrata Banik (Code Review)]

Attention is currently required from: John Zhao, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )

Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/common/block/tcss/tcss.c:

https://review.coreboot.org/c/coreboot/+/62723/comment/27e1729e_4bd0f1c1 
PS3, Line 389: 	else if (CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS_REG_ACCESS_SBI)) {
             : 		if (CONFIG(SOC_INTEL_COMMON_BLOCK_IOE_P2SB))
> It seems the current format to be more descriptive to differentiate the _REGBAR and _SBI. IOE_P2SB and XYZ_P2SB(TBD) are in the scope of _SBI.
>
> else if (CONFIG(SOC_INTEL_COMMON_BLOCK_REG_ACCESS_SBI)) { 
>     if (CONFIG(SOC_INTEL_COMMON_BLOCK_IOE_P2SB)) 
>         ioe_tcss_configure_aux_bias_pads_sbi(pads);
>     else if (CONFIG(SOC_INTEL_COMMON_BLOCK_XYZ_P2SB)) 
>         xyz_tcss_configure_aux_bias_pads_sbi(pads);
> }
>
> I have no objection to update the format if you insist on changing it.

Sure, do you see in future there would be more such interface even inside `else if (CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS_REG_ACCESS_SBI)) {` ?

I would prefer to combine as suggested, if we need to add such in future, we can do it later.