[S] Change in coreboot[master]: acpi: Add a runtime method to override exposed _Sx sleep states - coreboot-gerrit

25 Apr 2023


      Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 )
Change subject: acpi: Add a runtime method to override exposed _Sx sleep states
......................................................................
Patch Set 4:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74762/comment/2373b906_10dc818a 
PS4, Line 528: (enable_s1 << 0) | (enable_s2 << 1)
             : 		| (enable_s3 << 2) | (enable_s4 << 3)
maybe bitshifting 'bool' isn't the best idea...
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74762
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998
Gerrit-Change-Number: 74762
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Comment-Date: Tue, 25 Apr 2023 16:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment