Attention is currently required from: Jakub Czapiga, Julius Werner, Maximilian Brune.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email )
Change subject: commonlib/bsd: Add strlen() and strnlen() functions
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83830/comment/ea968074_b4fb3b18?usp... :
PS1, Line 12: return len;
nit: This is probably overthinking it, but I get a shorter loop in assembly with […]
Done
https://review.coreboot.org/c/coreboot/+/83830/comment/c5911bb5_a757906b?usp... :
PS1, Line 20: return len;
Here it would be […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83830?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Gerrit-Change-Number: 83830
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Fri, 09 Aug 2024 00:10:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org