Attention is currently required from: Paul Menzel.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71729 )
Change subject: soc/intel/baytrail/romstage: Fix uninitialized variable "speed"
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/baytrail/romstage/raminit.c:
https://review.coreboot.org/c/coreboot/+/71729/comment/ebdec159_1bce8a51
PS1, Line 111: printk(BIOS_INFO, "%dMHz\n", speed);
All cases are covered, so there is no problem.
Yes, but there's a warning from the compiler.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71729
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic62a15eb152a5c6fa3d41bb8d5f104f62f89808c
Gerrit-Change-Number: 71729
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 10 Jan 2023 00:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment