[XS] Change in coreboot[main]: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT

[SH Kim (Code Review)]

SH Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83346?usp=email )

Change subject: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT
......................................................................

mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT

If user continues to use the touchpad for over 3 minutes on Xol, the
pointer movement is stuttering.

Touchpad I2C transaction should appear during the interrupt signal level
is low, but we could see some more I2C transaction after the interrupt
signal(GPP_F14) went to high.

We found experimentally that changing the interrupt type to GPIO_INT
from APIC_IRQ improved this issue. We are still investigating, would
like to apply this change first for Xol's dogfooding.

BUG=b:350609957
BRANCH=brya
TEST=built and verified there's no stuttering issue on touchpad movement

Change-Id: Ie1b59355a694e5a42367a20e03f6c5f93225e79c
Signed-off-by: Seunghwan Kim 
---
M src/mainboard/google/brya/variants/xol/gpio.c
M src/mainboard/google/brya/variants/xol/overridetree.cb
2 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83346/1

diff --git a/src/mainboard/google/brya/variants/xol/gpio.c b/src/mainboard/google/brya/variants/xol/gpio.c
index 39478a1..fea66e4 100644
--- a/src/mainboard/google/brya/variants/xol/gpio.c
+++ b/src/mainboard/google/brya/variants/xol/gpio.c
@@ -119,6 +119,8 @@
    PAD_NC(GPP_F12, NONE),
    /* F13 : GSXDOUT ==> NC */
    PAD_NC(GPP_F13, NONE),
+	/* F14 : GSXDIN ==> TCHPAD_INT_ODL */
+	PAD_CFG_GPI_INT_LOCK(GPP_F14, NONE, LEVEL, LOCK_CONFIG),
    /* F15 : GSXSRESET# ==> PU 100K 3.3V */
    PAD_CFG_GPI(GPP_F15, NONE, DEEP),
    /* F16 : GSXCLK ==> NC */
diff --git a/src/mainboard/google/brya/variants/xol/overridetree.cb b/src/mainboard/google/brya/variants/xol/overridetree.cb
index d73702c..945b8b8 100644
--- a/src/mainboard/google/brya/variants/xol/overridetree.cb
+++ b/src/mainboard/google/brya/variants/xol/overridetree.cb
@@ -343,8 +343,7 @@
    		chip drivers/i2c/hid
    			register "generic.hid" = ""ZNT0000""
    			register "generic.desc" = ""Zinitix Touchpad""
-				register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)"
-				register "generic.wake" = "GPE0_DW2_14"
+				register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW_WAKE(GPP_F14)"
    			register "generic.detect" = "1"
    			register "hid_desc_reg_offset" = "0xE"
    			device i2c 40 on end