Change in ...coreboot[master]: x86/acpi: Fix Coverity issue CID 1399153

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31782

Change subject: x86/acpi: Fix Coverity issue CID 1399153
......................................................................

x86/acpi: Fix Coverity issue CID 1399153

This patch fixes Coverity issue
CID 1399153: Uninitialized variables  (UNINIT)

Change-Id: I736b532c687612912271317b8941e69f41af00ba
Signed-off-by: Werner Zeh 
---
M src/arch/x86/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/31782/1

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 623a6df..4e86195 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -150,7 +150,7 @@
 unsigned long acpi_create_madt_lapics(unsigned long current)
 {
    struct device *cpu;
-	int index, apic_ids[CONFIG_MAX_CPUS], num_cpus = 0;
+	int index, apic_ids[CONFIG_MAX_CPUS] = {0}, num_cpus = 0;

for (cpu = all_devices; cpu; cpu = cpu->next) {
    	if ((cpu->path.type != DEVICE_PATH_APIC) ||

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31782 )

Change subject: x86/acpi: Fix Coverity issue CID 1399153
......................................................................

Patch Set 2: Code-Review+2

Thanks, this one actually broke build with some old toolchain.

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31782 )

Change subject: x86/acpi: Fix Coverity issue CID 1399153
......................................................................

Patch Set 2: Code-Review+2

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31782 )

Change subject: x86/acpi: Fix Coverity issue CID 1399153
......................................................................

x86/acpi: Fix Coverity issue CID 1399153

This patch fixes Coverity issue
CID 1399153: Uninitialized variables  (UNINIT)

Change-Id: I736b532c687612912271317b8941e69f41af00ba
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31782
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/arch/x86/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 486f8e3..b51b5a6 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -150,7 +150,7 @@
 unsigned long acpi_create_madt_lapics(unsigned long current)
 {
    struct device *cpu;
-	int index, apic_ids[CONFIG_MAX_CPUS], num_cpus = 0;
+	int index, apic_ids[CONFIG_MAX_CPUS] = {0}, num_cpus = 0;

for (cpu = all_devices; cpu; cpu = cpu->next) {
    	if ((cpu->path.type != DEVICE_PATH_APIC) ||