Change in ...coreboot[master]: soc/intel/braswell: Correct code style - coreboot-gerrit

10 Dec 2018


      Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30126 )
Change subject: soc/intel/braswell: Correct code style
......................................................................
Patch Set 1:
...
Patch Set 1: Code-Review-1
Are you getting this as a warning from some tool? The coding style
states that braces should be used for both branches of an if-else if
at least one branch has multiple statements.
I was not aware of this if-else rule. (Noticed 'unnecessary braces for single statement blocks' only)
Shall I abondon this patch?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20
Gerrit-Change-Number: 30126
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Dec 2018 11:20:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment