Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Paul Menzel, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80663?usp=email )
Change subject: mb/google/rex/var/karis: Refactor SSD power sequencing
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80663/comment/23df4768_b67d2af8 :
PS4, Line 9: Improve SSD readiness time by enabling earlier power sequencing.
What are the old and new timings?
i do not believe this is a valid comment, as you would have understood the benefit by now by looking at the commit message. as mentioned in the commit msg that
```
bootblock (A20/0, A19/1)
|
v
romstage (A20/1)
```
bootblock and romstage are completing the power seq now compared to ramstage in the previous case. Now everyone knows what it means by completing power seq before ramstage. I don't believe that I have to give timing justification.
marking this open resolve.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79171a7830b75f5c20bbe30023f2814a62743a13
Gerrit-Change-Number: 80663
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 23 Feb 2024 17:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment