[S] Change in coreboot[main]: acpi: Add support for DRHD size reporting

[Shuo Liu (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeff Daly, Jincheng Li, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Nick Vaccaro, Nico Huber, Patrick Rudolph, Paul Menzel, Sean Rhodes, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio, Werner Zeh.

Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82429?usp=email )

Change subject: acpi: Add support for DRHD size reporting
......................................................................

Patch Set 17:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82429/comment/3babc5ce_5da3a431?usp... :
PS10, Line 18: TEST=Build and boot on intel/archercity CRB
> SPR has DRHD size as 4KB, the same as the default DRHD setting if size is not specified, and hence n […]

Please allow me to close the now and please feel free to raise new opens if any?

File src/acpi/acpi_dmar.c:

https://review.coreboot.org/c/coreboot/+/82429/comment/39f7cfcd_cc58b892?usp... :
PS16, Line 42: 	u16 segment, u64 bar)
> nit: […]

Done

https://review.coreboot.org/c/coreboot/+/82429/comment/a3628836_abd884ed?usp... :
PS16, Line 44: 1
> Since you kept the `size` parameter in bytes: […]

Sorry, good catch.

https://review.coreboot.org/c/coreboot/+/82429/comment/48eab6c5_ab079e6b?usp... :
PS16, Line 48: 	u16 segment, u64 bar, u32 size)
> nit: […]

Done

https://review.coreboot.org/c/coreboot/+/82429/comment/4de73f14_2f924773?usp... :
PS16, Line 60: 	 * Refer to chapter 8.3 of https://cdrdv2.intel.com/v1/dl/getContent/671081
> This is true for the the whole _drhd functions, maybe place above? […]

Done

https://review.coreboot.org/c/coreboot/+/82429/comment/fe5d6634_ff7f59d7?usp... :
PS16, Line 68: (1 << (drhd->size + 12)
> If `size` is less than 4 KiB and `drhd->size` ends up being 0, it is treated as if it were 1 (4 KiB) […]

Done

File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/82429/comment/50b818c6_9a7ccb20?usp... :
PS16, Line 1855: u32
> (`size` can't be greater than 128 MiB anyway, but yes. […]

Done