Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI
......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161606):
https://review.coreboot.org/c/coreboot/+/66992/comment/adda9e78_e0ca269c
PS13, Line 443: /* GPP_C23 : [] ==> FP_RST_ODL */
code indent should use tabs where possible
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e6be24e72a8232ae2c958a01cf8ea9a272d7365
Gerrit-Change-Number: 66992
Gerrit-PatchSet: 13
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 28 Oct 2022 21:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment