Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 )
Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41728/12/src/drivers/intel/fsp2_0/i... File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/41728/12/src/drivers/intel/fsp2_0/i... PS12, Line 24: enum fsp_multi_phase_action { : GET_NUMBER_OF_PHASES = 0, : EXECUTE_PHASE = 1 : }; : : struct fsp_multi_phase_get_number_of_phases_params { : uint32_t number_of_phases; : uint32_t phases_executed; : };
nit: Should these enum/structures be exposed externally?
Below is newly created entry point hence function prototype is here.
typedef asmlinkage uint32_t (*fsp_multi_phase_si_init_fn)(struct fsp_multi_phase_params *);
enum fsp_multi_phase_action is part of API structure hence need to here as well
They are being used in only silicon_init.c .
moved fsp_multi_phase_get_number_of_phases_params into silicon_init.c itself as its an intermediate call.
notify.c is also just calling those notify related function /macros (line 20-22)but they do exist here. Its more towards FSP spec symmetry
https://review.coreboot.org/c/coreboot/+/41728/11/src/drivers/intel/fsp2_0/u... File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/41728/11/src/drivers/intel/fsp2_0/u... PS11, Line 53: multi_phase_si_init_entry_offset
Do you want to log the offset in the ""src/drivers/intel/fsp2_0/header_display. […]
Done