[S] Change in coreboot[master]: soc/amd/stoneyridge/northbridge: use common acpi_fill_root_complex_tom

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74303 )

Change subject: soc/amd/stoneyridge/northbridge: use common acpi_fill_root_complex_tom
......................................................................

soc/amd/stoneyridge/northbridge: use common acpi_fill_root_complex_tom

Use the common acpi_fill_root_complex_tom function instead of the SoC-
level northbridge_fill_ssdt_generator function that does basically the
same.

TEST=Resulting coreboot SSDT remains unchanged on Careena.

Signed-off-by: Felix Held 
Change-Id: Ie0f100e0766ce0f826daceba7dbec1fb88492938
---
M src/soc/amd/stoneyridge/northbridge.c
1 file changed, 18 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/74303/1

diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index 7913827..b1d2bdd 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <assert.h>
+#include <amdblocks/acpi.h>
 #include <amdblocks/biosram.h>
 #include <amdblocks/hda.h>
 #include <device/pci_ops.h>
@@ -186,27 +187,6 @@
    return (unsigned long)current;
 }

-static void northbridge_fill_ssdt_generator(const struct device *device)
-{
-	msr_t msr;
-	char pscope[] = "\_SB.PCI0";
-
-	acpigen_write_scope(pscope);
-	msr = rdmsr(TOP_MEM);
-	acpigen_write_name_dword("TOM1", msr.lo);
-	msr = rdmsr(TOP_MEM2);
-	/*
-	 * Since XP only implements parts of ACPI 2.0, we can't use a qword
-	 * here.
-	 * See http://www.acpi.info/presentations/S01USMOBS169_OS%2520new.ppt
-	 * slide 22ff.
-	 * Shift value right by 20 bit to make it fit into 32bit,
-	 * giving us 1MB granularity and a limit of almost 4Exabyte of memory.
-	 */
-	acpigen_write_name_dword("TOM2", (msr.hi << 12) | msr.lo >> 20);
-	acpigen_pop_len();
-}
-
 static unsigned long agesa_write_acpi_tables(const struct device *device,
    				     unsigned long current,
    				     acpi_rsdp_t *rsdp)
@@ -285,7 +265,7 @@
    .set_resources	  = set_resources,
    .enable_resources = pci_dev_enable_resources,
    .init		  = northbridge_init,
-	.acpi_fill_ssdt   = northbridge_fill_ssdt_generator,
+	.acpi_fill_ssdt   = acpi_fill_root_complex_tom,
    .write_acpi_tables = agesa_write_acpi_tables,
 };