Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76138?usp=email )
Change subject: mb/google/rex/var/ovis: Enable SaGv
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/76138/comment/bed3d5b5_940c136a :
PS1, Line 44: register "sagv_freq_mhz[0]" = "3200"
maybe gather together as array assigning?
Acknowledged
https://review.coreboot.org/c/coreboot/+/76138/comment/8b6d4172_8fa0d944 :
PS1, Line 53: register "sagv_freq_mhz[3]" = "5600"
curious why we back to gear2 here?
I don't have any good answer to your question except this what we found as per the doc
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76138?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9703344a8ae9d2ba44a16c62afab820fd8e2177
Gerrit-Change-Number: 76138
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 04:28:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment