Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Jon Murphy, Martin Roth, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held, Mark Hasemeyer.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74591 )
Change subject: soc/amd/common: Update GPIO macros
......................................................................
Patch Set 5: Verified-1
(3 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174786):
https://review.coreboot.org/c/coreboot/+/74591/comment/9680dd36_35807aba
PS5, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174786):
https://review.coreboot.org/c/coreboot/+/74591/comment/c8697938_b017e811
PS5, Line 11: to GPIO_NN names for use in their own development. Enabling projects to
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174786):
https://review.coreboot.org/c/coreboot/+/74591/comment/580afcdd_dffe8396
PS5, Line 12: rename their own GPIOs to nets will hopefully make the code more readable
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I918d659eecf2076ed9089218177874ed2c9023b3
Gerrit-Change-Number: 74591
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 22:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment