Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35406 )
Change subject: soc/intel/common/block: Stitch CSE blobs into FW_MAIN_X partitions
......................................................................
Patch Set 65:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35406/65/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35406/65/src/soc/intel/common/block...
PS65, Line 12: sync
: sleep 1
I think these are necessary because all of the other steps that touch coreboot.pre are in common/firmware/Makefile.inc and done in order, so I think we've got a race condition here. I think this either needs to be somehow synchronized with the other makefile, or this update step could be added there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35406
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d2908e9e16858c5f333e1b10b19d18b7ca27765
Gerrit-Change-Number: 35406
Gerrit-PatchSet: 65
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 17 Jul 2020 20:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment