Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41029 )
Change subject: soc/intel/jasperlake: Allow SataEnable to be filled from devicetree
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG@11
PS4, Line 11: it can be set as per each board's requirement.
- Why can’t this be detected at run-time? […]
here in this we are changing FSP UPD value as per board's requirement. It will override FSP UPD default value. FSP will try to initialize SATA controller if this UPD is set to 1. if board is not using SATA then it is better to make this UPD off so FSP will not try to initialize SATA controller.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f7e7508b8cd483508293ee3e7b760574d8f025f
Gerrit-Change-Number: 41029
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 May 2020 12:41:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment