Attention is currently required from: Martin L Roth, Jan Dabros, Martin Roth, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67917 )
Change subject: arch/x86/include: Split msr access into separate file ......................................................................
Patch Set 3:
(1 comment)
File src/include/cpu/x86/msr_access.h:
https://review.coreboot.org/c/coreboot/+/67917/comment/32fa7bcc_0364678e PS3, Line 30: /* The following functions require the __always_inline due to AMD : * function STOP_CAR_AND_CPU that disables cache as : * RAM, the cache as RAM stack can no longer be used. Called : * functions must be inlined to avoid stack usage. Also, the : * compiler must keep local variables register based and not : * allocated them from the stack. With gcc 4.5.0, some functions : * declared as inline are not being inlined. This patch forces : * these functions to always be inlined by adding the qualifier : * __always_inline to their declaration. : */
I agree, but this patch is a simple move.
Oh, forgot to explicitly indicate that this is meant for another patch.