Attention is currently required from: Tim Wawrzynczak, Angel Pons, Julius Werner, Gwendal Grignou.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50210 )
Change subject: drivers/i2c: sx9310: Use open source variables
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/i2c/sx9310/registers.h:
https://review.coreboot.org/c/coreboot/+/50210/comment/50c9edda_f934cad6
PS4, Line 7: reg_prox_ctrl0
Another board needs to be fixed along with this: nocturne (https://qa.coreboot.org/job/coreboot-gerrit/164590/testReport/junit/(root)/b...)
File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50210/comment/8bc1c9bb_e245cd7a
PS4, Line 158: -
_ instead of -
(https://qa.coreboot.org/job/coreboot-gerrit/164590/testReport/junit/board/ch...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b
Gerrit-Change-Number: 50210
Gerrit-PatchSet: 4
Gerrit-Owner: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment