Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80700?usp=email )
Change subject: soc/amd/common/acp: use clrsetbits32p to avoid need for casts ......................................................................
soc/amd/common/acp: use clrsetbits32p to avoid need for casts
Use clrsetbits32p instead of clrsetbits32 to not need to cast the uintptr_t address to void * in the function call.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ic29bf04866a7e1d5c831422f31803a724a41069b Reviewed-on: https://review.coreboot.org/c/coreboot/+/80700 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/amd/common/block/acp/acp_gen1.c M src/soc/amd/common/block/acp/acp_gen2.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/amd/common/block/acp/acp_gen1.c b/src/soc/amd/common/block/acp/acp_gen1.c index 0fe37f3..4bfd711 100644 --- a/src/soc/amd/common/block/acp/acp_gen1.c +++ b/src/soc/amd/common/block/acp/acp_gen1.c @@ -17,7 +17,7 @@
static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set) { - clrsetbits32((void *)(bar + reg), clear, set); + clrsetbits32p(bar + reg, clear, set); }
void acp_init(struct device *dev) diff --git a/src/soc/amd/common/block/acp/acp_gen2.c b/src/soc/amd/common/block/acp/acp_gen2.c index 50de4b0..be24ec9 100644 --- a/src/soc/amd/common/block/acp/acp_gen2.c +++ b/src/soc/amd/common/block/acp/acp_gen2.c @@ -17,7 +17,7 @@
static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set) { - clrsetbits32((void *)(bar + reg), clear, set); + clrsetbits32p(bar + reg, clear, set); }
void acp_init(struct device *dev)