Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74717?usp=email )
Change subject: soc/amd/common/data_fabric/domain: provide scan_bus and read_resources
......................................................................
Patch Set 18:
(1 comment)
File src/soc/amd/common/block/data_fabric/domain.c:
https://review.coreboot.org/c/coreboot/+/74717/comment/e9acf2d7_6be87a44 :
PS18, Line 144: /* TODO: Systems with more than one PCI root need to read the data fabric registers to
: see which IO ranges get decoded to which PCI root. */
:
: res = new_resource(domain, (*idx)++);
: res->base = 0;
: res->limit = 0xffff;
: res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED;
This is allocated bottom up iirc, so unlikely to cause trouble with reasonable resource usage. […]
i already started working on some follow-up patches that read this info from the DF registers. for my case hard-coding this at first was sufficient, but i'm definitely planning to do this properly in a follow-up
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aada7c8a2a43145ad08d11d0a38d9cdc182b98e
Gerrit-Change-Number: 74717
Gerrit-PatchSet: 18
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 06 Jun 2023 19:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment