Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38407 )
Change subject: mb/google/link: drop dummy mainboard_post function ......................................................................
mb/google/link: drop dummy mainboard_post function
It was never filled it, it probably never will be filled in, so stop the pretense.
Change-Id: I7632b763b8518304d36a818ce262cc127f95b9f0 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/link/mainboard.c 1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38407/1
diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c index 5a812e8..8be4012 100644 --- a/src/mainboard/google/link/mainboard.c +++ b/src/mainboard/google/link/mainboard.c @@ -32,20 +32,6 @@ #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/chromeos.h>
-/* placeholder for evenual link post. Not sure what we'll - * do but it will look nice - */ -void mainboard_post(u8 value) -{ - /* - * What you DO NOT want to do: push every post to the EC backlight. - * it seems cute but in practice it looks like a hardware failure. - * I'm leaving this here so we don't make this mistake again later. - * And it seems to break the SMP startup. - * google_chromeec_post(value); - */ -} - #if CONFIG(VGA_ROM_RUN) static int int15_handler(void) {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38407 )
Change subject: mb/google/link: drop dummy mainboard_post function ......................................................................
Patch Set 1: Code-Review+2
It surely looks nice now that it's not there :D
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38407 )
Change subject: mb/google/link: drop dummy mainboard_post function ......................................................................
mb/google/link: drop dummy mainboard_post function
It was never filled it, it probably never will be filled in, so stop the pretense.
Change-Id: I7632b763b8518304d36a818ce262cc127f95b9f0 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38407 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/link/mainboard.c 1 file changed, 0 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c index 5a812e8..8be4012 100644 --- a/src/mainboard/google/link/mainboard.c +++ b/src/mainboard/google/link/mainboard.c @@ -32,20 +32,6 @@ #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/chromeos.h>
-/* placeholder for evenual link post. Not sure what we'll - * do but it will look nice - */ -void mainboard_post(u8 value) -{ - /* - * What you DO NOT want to do: push every post to the EC backlight. - * it seems cute but in practice it looks like a hardware failure. - * I'm leaving this here so we don't make this mistake again later. - * And it seems to break the SMP startup. - * google_chromeec_post(value); - */ -} - #if CONFIG(VGA_ROM_RUN) static int int15_handler(void) {
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)