Attention is currently required from: Felix Singer, Angel Pons, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52843 )
Change subject: soc/intel/skylake: Clean up FSP chipset lockdown configuration ......................................................................
Patch Set 6: Code-Review+1
(5 comments)
Patchset:
PS6: Tested? (I don't expect any issues but I could sleep better ;) )
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/52843/comment/f481a3ed_6139103d PS6, Line 424: tconfig->PchLockDownBiosInterface = 0; defaults to 1 (see bsf) -> no behaviour change
https://review.coreboot.org/c/coreboot/+/52843/comment/1262f4e0_d8a9e38b PS6, Line 425: params->PchLockDownBiosLock = 0; defaults to 0 (see bsf) -> changes behaviour
https://review.coreboot.org/c/coreboot/+/52843/comment/864157bf_ed726db7 PS6, Line 426: params->PchLockDownSpiEiss = 0; defaults to 1 (see bsf) -> no behaviour change
https://review.coreboot.org/c/coreboot/+/52843/comment/9c6b30d8_b413677b PS6, Line 434: params->SpiFlashCfgLockDown = 0; defaults to 1 (see bsf) -> no behaviour change