Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Wonkyu Kim.
Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84210?usp=email )
Change subject: src/intel/cmm/block: Update sa_get_tseg_size function
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/84210/comment/332cab5b_3717ae88?usp... :
PS2, Line 155: return sa_get_gsm_base() - sa_get_tseg_base();
WDYT? I assume in absence of IGD the GSM size would be zero hence, we won't get into `if` case.
```
if (sa_get_gsm_size() > 0)
return sa_get_gsm_base() - sa_get_tseg_base();
else
return CONFIG_SMM_TSEG_SIZE;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84210?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3d5175add1f7dc6e2c9f1c38133b36ffc59e789
Gerrit-Change-Number: 84210
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Comment-Date: Sat, 07 Sep 2024 08:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No