Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83923?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add NOR-Flash support ......................................................................
Patch Set 3:
(4 comments)
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/83923/comment/a0ed82a1_5d6edbb6?usp... : PS3, Line 35: = NULL initialization not needed.
https://review.coreboot.org/c/coreboot/+/83923/comment/6acefdbb_9c8a4820?usp... : PS3, Line 39: gpio_set_pull(ptr[i].gpio, GPIO_PULL_ENABLE, ptr[i].select); Set `ptr = nor_pinmux[i]` here, not `ptr = nor_pinmux` in line #37.
https://review.coreboot.org/c/coreboot/+/83923/comment/d70f8e58_25d8009a?usp... : PS3, Line 44: "%s Align with `BIOS_ERR`.
https://review.coreboot.org/c/coreboot/+/83923/comment/abbe5a19_db93d2e4?usp... : PS3, Line 48: gpio_get_driving(ptr[i].gpio)); Align.