Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support ......................................................................
Patch Set 17:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85126/comment/80801639_c74430dc?usp... : PS17, Line 13: TEST=build pass Were you able to run-time test it? Maybe print the new log messages.
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/2c564f0a_12703761?usp... : PS17, Line 190: int size_t
https://review.coreboot.org/c/coreboot/+/85126/comment/93b9a28f_6b46346e?usp... : PS17, Line 345: spmi SPMI
-
Paul Menzel (Code Review)