Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6373 driver ......................................................................
Patch Set 33:
(6 comments)
File src/soc/mediatek/common/include/soc/mt6373.h:
https://review.coreboot.org/c/coreboot/+/85129/comment/940abef9_c2902b17?usp... : PS33, Line 78: #endif /* __SOC_MEDIATEK_MT6373_H__ */ Blank line above.
File src/soc/mediatek/common/mt6373.c:
https://review.coreboot.org/c/coreboot/+/85129/comment/e7234abd_d6d2b862?usp... : PS33, Line 24: u32 u8
https://review.coreboot.org/c/coreboot/+/85129/comment/e6057228_d83cdda0?usp... : PS33, Line 46: lock Align
https://review.coreboot.org/c/coreboot/+/85129/comment/89047c7d_61f84432?usp... : PS33, Line 56: ( These parentheses can be removed.
https://review.coreboot.org/c/coreboot/+/85129/comment/74f4e12c_f43d138e?usp... : PS33, Line 88: ( Remove. Same for other similar functions.
https://review.coreboot.org/c/coreboot/+/85129/comment/d68df2ac_0e5b62fa?usp... : PS33, Line 109: Extra blank line.