Change in coreboot[master]: util/cbfstool: Add "expand" command to make CBFS span an fmap region - coreboot-gerrit

19 Sep 2017


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21598 )
Change subject: util/cbfstool: Add "expand" command to make CBFS span an fmap region
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c@1114
PS1, Line 1114: 	/* Obtain the source region. */
...
nit: Shouldn't this default to COREBOOT like the other commands? (Or, if it
You're right. I originally used source_region which needs this guard. Fixed.
-- 
To view, visit https://review.coreboot.org/21598
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1
Gerrit-Change-Number: 21598
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Caveh Jalali caveh@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Sep 2017 20:17:43 +0000
Gerrit-HasComments: Yes