[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VIO18 - coreboot-gerrit

13 Apr 2023


      Attention is currently required from: Hung-Te Lin, cong yang, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74341 )
Change subject: soc/mediatek: Add support for regulator VIO18
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/74341/comment/d68094b7_b2385217 
PS7, Line 17: #define VIO18_VOLTAGE_UV 1800000
Move to line 792.
https://review.coreboot.org/c/coreboot/+/74341/comment/5372820a_713a18f4 
PS7, Line 797: voltage_uv
what about `vio18_uv` ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 7
Gerrit-Owner: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 06:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment