Attention is currently required from: Eric Lai, Felix Singer, Jan Samek, Sean Rhodes, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75820?usp=email )
Change subject: soc/intel/apollolake: Fix FSP SATA speed limit configuraion
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75820/comment/41ade795_06f27ab3 :
PS5, Line 21: SATA configuration via dmesg
Maybe more detailed, usually there is something like: […]
Done
File src/soc/intel/apollolake/ahci.c:
https://review.coreboot.org/c/coreboot/+/75820/comment/21b685c9_7307349b :
PS5, Line 12:
'is set, ' or 'is given, ', ... […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/75820/comment/70cb5fc0_d871d32d :
PS5, Line 21: u
I think, the enum type defaults to int in C, therefore `%d`.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75820?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f55f40941fa618e7de13a5cefe9e17ae34c5c99
Gerrit-Change-Number: 75820
Gerrit-PatchSet: 7
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 10:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment