Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Ravishankar Sarawadi, Subrata Banik, Julius Werner, Nick Vaccaro, Raj Astekar, Srinidhi N Kaushik.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58833 )
Change subject: src/lib: Support fallback option for fw_config
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58833/comment/ecab93f9_3f80296e
PS7, Line 7: src/lib: Support fallback option for fw_config
:
: To support both non-chrome EC platform and chrome EC platform in
: single coreboot binary, need to support fallback option.
: Make reading fw_config from CBI and support other options as
: fallback options and support backward compatiblity to support only one
: option as before.
Sorry, but this confuses readers more than it helps explain what's going on here.
How about:
src/lib/fw_config: Change fw_config sources priority
Request fw_config values from various sources (as enabled via Kconfig) until
a valid value has been read.
With this change, Chrome EC CBI takes precedence over CBFS fw_config.
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/58833/comment/65433007_bfae7c90
PS7, Line 408: config FW_CONFIG_SOURCE_CBFS
Why move this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58833
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I215c13a4fcb9dc3b94f73c770e704d4e353e9cff
Gerrit-Change-Number: 58833
Gerrit-PatchSet: 7
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Comment-Date: Fri, 05 Nov 2021 12:51:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment