Attention is currently required from: Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization codes
......................................................................
Patch Set 9:
(5 comments)
File src/vendorcode/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/50294/comment/b2769ec1_839e1d3b
PS8, Line 7: #
remove this comment?
File src/vendorcode/mediatek/Kconfig:
https://review.coreboot.org/c/coreboot/+/50294/comment/f74dae0f_95c8e200
PS9, Line 9: config MT8192_DRAM_EMCP
: bool
: default y
: help
: The eMCP platform should select this option to run at different DRAM
: frequencies.
Is this still used? I thought we are using sdram_params for EMCP now.
File src/vendorcode/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/50294/comment/59f4dca7_cd5c2cab
PS9, Line 7: ramstage-y += dpm.c
why is dpm included?
https://review.coreboot.org/c/coreboot/+/50294/comment/57a8d5df_8f6e4783
PS9, Line 9: BL31_MAKEARGS += PLAT=mt8192
we don't need this?
File src/vendorcode/mediatek/mt8192/dpm.c:
https://review.coreboot.org/c/coreboot/+/50294/comment/86486115_980f5621
PS9, Line 1: License
dpm should not be in DRAM code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4
Gerrit-Change-Number: 50294
Gerrit-PatchSet: 9
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
reinauer@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 01 Mar 2021 08:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment