HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab
Change-Id: I0c606fd129c200446744f7a67ae63fec6d8e1684 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/nvidia/tegra124/include/soc/clk_rst.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/46328/1
diff --git a/src/soc/nvidia/tegra124/include/soc/clk_rst.h b/src/soc/nvidia/tegra124/include/soc/clk_rst.h index 0b0e025..cfddd10 100644 --- a/src/soc/nvidia/tegra124/include/soc/clk_rst.h +++ b/src/soc/nvidia/tegra124/include/soc/clk_rst.h @@ -257,7 +257,7 @@ u32 spare_reg0; /* _SPARE_REG0, 0x55c */ u32 _rsv32[4]; /* 0x560-0x56c */ u32 plld2_ss_cfg; /* _PLLD2_SS_CFG 0x570 */ - u32 _rsv32_1[7]; /* 0x574-58c */ + u32 _rsv32_1[7]; /* 0x574-58c */ u32 plldp_base; /* _PLLDP_BASE, 0x590 */ u32 plldp_misc; /* _PLLDP_MISC, 0x594 */ u32 plldp_ss_cfg; /* _PLLDP_SS_CFG, 0x598 */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... File src/soc/nvidia/tegra124/include/soc/clk_rst.h:
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... PS1, Line 138: clk_enb_u_clk; Julius, shouldn't this be 'clk_enb_u_clc' as in the comment or the comment is wrong ?
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
Patch Set 1:
(1 comment)
Thank you
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... File src/soc/nvidia/tegra124/include/soc/clk_rst.h:
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... PS1, Line 138: clk_enb_u_clk;
Julius, […]
Oops, I mean 'clk_enb_u_clr' :)
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... File src/soc/nvidia/tegra124/include/soc/clk_rst.h:
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... PS1, Line 138: clk_enb_u_clk;
Oops, I mean 'clk_enb_u_clr' :)
Probably, yeah. This chipset is ancient, I don't think anyone really cares about it anymore, but feel free to fix if you want to.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... File src/soc/nvidia/tegra124/include/soc/clk_rst.h:
https://review.coreboot.org/c/coreboot/+/46328/1/src/soc/nvidia/tegra124/inc... PS1, Line 138: clk_enb_u_clk;
Probably, yeah. […]
Ack
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46328 )
Change subject: soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab ......................................................................
soc/nvidia/tegra124/include/soc/clk_rst.h: Remove extra tab
Change-Id: I0c606fd129c200446744f7a67ae63fec6d8e1684 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46328 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/nvidia/tegra124/include/soc/clk_rst.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/nvidia/tegra124/include/soc/clk_rst.h b/src/soc/nvidia/tegra124/include/soc/clk_rst.h index 0b0e025..cfddd10 100644 --- a/src/soc/nvidia/tegra124/include/soc/clk_rst.h +++ b/src/soc/nvidia/tegra124/include/soc/clk_rst.h @@ -257,7 +257,7 @@ u32 spare_reg0; /* _SPARE_REG0, 0x55c */ u32 _rsv32[4]; /* 0x560-0x56c */ u32 plld2_ss_cfg; /* _PLLD2_SS_CFG 0x570 */ - u32 _rsv32_1[7]; /* 0x574-58c */ + u32 _rsv32_1[7]; /* 0x574-58c */ u32 plldp_base; /* _PLLDP_BASE, 0x590 */ u32 plldp_misc; /* _PLLDP_MISC, 0x594 */ u32 plldp_ss_cfg; /* _PLLDP_SS_CFG, 0x598 */
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)