Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42981 )
Change subject: pgtblgen: Update comment to match what the code does ......................................................................
pgtblgen: Update comment to match what the code does
Change-Id: Ib87c804b139a96a4173a6f392f0f99a77d32fc01 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M util/pgtblgen/pgtblgen.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/42981/1
diff --git a/util/pgtblgen/pgtblgen.c b/util/pgtblgen/pgtblgen.c index 27114ed..640d0ba 100644 --- a/util/pgtblgen/pgtblgen.c +++ b/util/pgtblgen/pgtblgen.c @@ -23,7 +23,7 @@ * For reference see "AMD64 ArchitectureProgrammer's Manual Volume 2", * Document 24593-Rev. 3.31-July 2019 Chapter 5.3.4 * - * Page table attributes: WB, User+Supervisor, Present, Writeable + * Page table attributes: WB, User+Supervisor, Present, Writeable, Accessed, Dirty */ #define _PRES (1ULL << 0) #define _RW (1ULL << 1)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42981 )
Change subject: pgtblgen: Update comment to match what the code does ......................................................................
Patch Set 1: Code-Review+1
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42981 )
Change subject: pgtblgen: Update comment to match what the code does ......................................................................
Patch Set 1: Code-Review+2
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42981 )
Change subject: pgtblgen: Update comment to match what the code does ......................................................................
pgtblgen: Update comment to match what the code does
Change-Id: Ib87c804b139a96a4173a6f392f0f99a77d32fc01 Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/42981 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M util/pgtblgen/pgtblgen.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved
diff --git a/util/pgtblgen/pgtblgen.c b/util/pgtblgen/pgtblgen.c index 27114ed..640d0ba 100644 --- a/util/pgtblgen/pgtblgen.c +++ b/util/pgtblgen/pgtblgen.c @@ -23,7 +23,7 @@ * For reference see "AMD64 ArchitectureProgrammer's Manual Volume 2", * Document 24593-Rev. 3.31-July 2019 Chapter 5.3.4 * - * Page table attributes: WB, User+Supervisor, Present, Writeable + * Page table attributes: WB, User+Supervisor, Present, Writeable, Accessed, Dirty */ #define _PRES (1ULL << 0) #define _RW (1ULL << 1)
-
Patrick Rudolph (Code Review) -
Paul Menzel (Code Review)
-
Philipp Deppenwiese (Code Review)