Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55455 )
Change subject: amdfwtool: Use command line option use-combo to decide if use combo ......................................................................
Patch Set 21:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/55455/comment/0c5f5230_1a6422e2 PS20, Line 1567: if (comboable) : amd_romsig->new_psp_directory = BUFF_TO_RUN(ctx, pspdir); : else : amd_romsig->psp_directory = BUFF_TO_RUN(ctx, pspdir); : : if (cb_config.use_combo) { : psp_combo_directory *combo_dir = new_combo_dir(&ctx); : amd_romsig->combo_psp_directory = BUFF_TO_RUN(ctx, combo_dir); : /* 0 -Compare PSP ID, 1 -Compare chip family ID */ : combo_dir->entries[0].id_sel = 0; : combo_dir->entries[0].id = get_psp_id(cb_config.soc_id); : combo_dir->entries[0].lvl2_addr = BUFF_TO_RUN(ctx, pspdir); : : combo_dir->header.lookup = 1; : fill_dir_header(combo_dir, 1, PSP2_COOKIE, &ctx); : }
create a new function to set psp_directory. […]
Done