Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30128 )
Change subject: siemens/mc_apl4: Add GPIO configuration ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c:
https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/varian... PS2, Line 28: */ one more - sorry, I overlooked it at first
https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/varian... PS2, Line 141: */ same
https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/varian... PS2, Line 232: */ same
https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/varian... PS2, Line 321: Wrong syntax for a comment
-
Mario Scheithauer (Code Review)