Change in coreboot[master]: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for h...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kane Chen (Code Review)

20 Dec 2019 20 Dec '19

5:56 a.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37866 )

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch""

This reverts commit b1ea707bdaf064ae1d2427e5e3c20d2ab66bf93d.

Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37866/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 7382209..a2831e1 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,6 +58,8 @@

+ register "PchPmSlpS0Vm075VSupport" = "1" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Kane Chen (Code Review)

20 Dec 20 Dec

5:58 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37866

to look at the new patch set (#2).

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch""

This reverts commit b1ea707bdaf064ae1d2427e5e3c20d2ab66bf93d.

Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37866/2

Kane Chen (Code Review)

24 Dec 24 Dec

5:29 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37866

to look at the new patch set (#3).

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch""

This reverts commit b1ea707bdaf064ae1d2427e5e3c20d2ab66bf93d.

Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc Signed-off-by: Kane Chen kane.chen@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37866/3

Subrata Banik (Code Review)

5:52 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37866 )

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc Gerrit-Change-Number: 37866 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 24 Dec 2019 05:52:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kane Chen (Code Review)

8:34 a.m.

Hello Subrata Banik, Tim Wawrzynczak, Aamir Bohra, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37866

to look at the new patch set (#4).

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch""

This reverts commit b1ea707bdaf064ae1d2427e5e3c20d2ab66bf93d.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37866/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc Gerrit-Change-Number: 37866 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Aamir Bohra (Code Review)

8:55 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37866 )

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc Gerrit-Change-Number: 37866 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 24 Dec 2019 08:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

8 Jan 8 Jan

10:01 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37866 )

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Patch Set 5:

Reason for reverting a revert? I would guess it's that runtime s0ix is fixed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc Gerrit-Change-Number: 37866 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jan 2020 22:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:19 p.m.

New subject: [XS] Change in coreboot[master]: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for h...

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37866?usp=email )

Change subject: Revert "Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"" ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4cc0e1c176d39d7c85a5298093852df5fc229fc Gerrit-Change-Number: 37866 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Aamir Bohra aamirbohra@google.com Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

285

days inactive

1611

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Aamir Bohra (Code Review)
Angel Pons (Code Review)
Kane Chen (Code Review)
Martin L Roth (Code Review)
Subrata Banik (Code Review)