Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61133 )
Change subject: soc/mediatek/mt8186: Support DRAM fast calibration using blob
......................................................................
Patch Set 25:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61133/comment/34a7a912_11cecc69
PS25, Line 15: Starting with MT8186 the implementation of fast calibration may need
: to be changed, and a "DRAM blob" only path is introduced for devices
: that has to do both full and fast calibration using the external blob.
Paul, does this sound good to you?
Yes, thank you. Minor nit: … that have to do …
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If25a7dd6aa6261ecff79a1b4df8b1f2e53d896dc
Gerrit-Change-Number: 61133
Gerrit-PatchSet: 25
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ron Minnich
rminnich@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sat, 29 Jan 2022 20:02:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment