Attention is currently required from: Tim Wawrzynczak. Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56387 )
Change subject: mb/google/brya: move the common config to the baseboard ......................................................................
mb/google/brya: move the common config to the baseboard
This patch moves the common config to the Kconfig under BOARD_GOOGLE_BASEBOARD_BRYA and remove the redundant config.
BUG=b:191472401 BRANCH=None TEST=build pass
Change-Id: Ie59299dfaba6bb23758d4a4c22a6dbbb4ba6520e Signed-off-by: Zhuohao Lee zhuohao@chromium.org --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56387/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 58635e9..f791846 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -30,14 +30,12 @@ select MAINBOARD_HAS_TPM2 select SOC_INTEL_ALDERLAKE select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3 + select SOC_INTEL_CRASHLOG select SOC_INTEL_CSE_LITE_SKU + select SYSTEM_TYPE_LAPTOP
if BOARD_GOOGLE_BASEBOARD_BRYA
-config BASEBOARD_BRYA_LAPTOP - def_bool n - select SYSTEM_TYPE_LAPTOP - config CHROMEOS select CHROMEOS_DRAM_PART_NUMBER_IN_CBI select EC_GOOGLE_CHROMEEC_SWITCHES @@ -70,7 +68,7 @@
config MAINBOARD_FAMILY string - default "Google_Brya0" if BOARD_GOOGLE_BRYA0 + default "Google_Brya"
config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 4d1748e..c37f135 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -1,23 +1,18 @@ config BOARD_GOOGLE_BRYA0 bool "Brya 0" select BOARD_GOOGLE_BASEBOARD_BRYA - select BASEBOARD_BRYA_LAPTOP - select BOARD_ROMSIZE_KB_32768 select ADL_ENABLE_USB4_PCIE_RESOURCES select DRIVERS_GENESYSLOGIC_GL9755 select DRIVERS_INTEL_MIPI_CAMERA select SOC_INTEL_COMMON_BLOCK_IPU - select SOC_INTEL_CRASHLOG
config BOARD_GOOGLE_PRIMUS bool "-> Primus" select BOARD_GOOGLE_BASEBOARD_BRYA - select BASEBOARD_BRYA_LAPTOP
config BOARD_GOOGLE_GIMBLE bool "-> Gimble" select BOARD_GOOGLE_BASEBOARD_BRYA - select BASEBOARD_BRYA_LAPTOP select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_MAX98390